Skip to content

upd - #109

Merged
AndreiDrang merged 12 commits into
prodfrom
main
Jul 21, 2026
Merged

upd#109
AndreiDrang merged 12 commits into
prodfrom
main

Conversation

@AndreiDrang

Copy link
Copy Markdown
Member

No description provided.

lovable-dev Bot and others added 12 commits July 20, 2026 00:54
Co-authored-by: AndreiDrang <16991365+AndreiDrang@users.noreply.github.com>
Co-authored-by: AndreiDrang <16991365+AndreiDrang@users.noreply.github.com>
X-Lovable-Edit-ID: edt-cefa01f9-5275-452a-8b42-44144331ccfb
Co-authored-by: AndreiDrang <16991365+AndreiDrang@users.noreply.github.com>
Co-authored-by: AndreiDrang <16991365+AndreiDrang@users.noreply.github.com>
X-Lovable-Edit-ID: edt-b123a04b-e693-4751-a4ba-726374fbc146
Co-authored-by: AndreiDrang <16991365+AndreiDrang@users.noreply.github.com>
Co-authored-by: AndreiDrang <16991365+AndreiDrang@users.noreply.github.com>
X-Lovable-Edit-ID: edt-3ae7fd3d-220b-4d68-997c-7b3902bc913f
Co-authored-by: AndreiDrang <16991365+AndreiDrang@users.noreply.github.com>
Co-authored-by: AndreiDrang <16991365+AndreiDrang@users.noreply.github.com>
Co-authored-by: AndreiDrang <16991365+AndreiDrang@users.noreply.github.com>
Co-authored-by: AndreiDrang <16991365+AndreiDrang@users.noreply.github.com>
X-Lovable-Edit-ID: edt-48469a20-8aa5-4d63-badc-f9840d4fd426
Co-authored-by: AndreiDrang <16991365+AndreiDrang@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Z.ai Code Review

🔍 Review Summary

This Pull Request introduces several highly beneficial SEO and accessibility improvements, notably fixing invalid Twitter card meta tags, enhancing OpenGraph data, and improving UI color contrast. However, it also introduces a critical SEO conflict regarding the canonical domain URLs in the sitemap.xml and robots.txt files, and presents a potential supply chain security risk in the dependency lock file.

🚨 Critical Issues & Bugs

  • public/sitemap.xml & public/robots.txt: The URLs have been changed from the primary production domain (tokenbel.info) to what appears to be a staging or platform domain (tokenbel.lovable.app). This directly contradicts the canonical URLs defined in the HTML files (e.g., <link rel="canonical" href="https://tokenbel.info/pricing/" /> in pricing/index.html). Submitting a sitemap with staging URLs for a production domain will severely confuse search engine crawlers, potentially resulting in de-indexing or duplicate content penalties.
    • Fix: Revert these URLs back to the target production domain.
      <!-- In sitemap.xml -->
      <loc>https://tokenbel.info/</loc>
      
      <!-- In robots.txt -->
      Sitemap: https://tokenbel.info/sitemap.xml

💡 Suggestions & Best Practices

  • bun.lock: The handlebars package resolution has been changed from the standard npm registry to a custom proxy/cache (https://europe-west1-npm.pkg.dev/lovable-core-prod/sandbox-npm-cache/...). If this project is open-source or intended to be run by external contributors, relying on private or non-standard artifact registries can break dependency installation for other developers and introduces a supply chain risk. Unless this is a strictly enforced corporate policy, it is generally safer to resolve packages from the default public registry.
  • partials/header.html & partials/footer.html: The updated alt text for the logo image is quite verbose ("Логотип TokenBel — информационная платформа для инвестиций в токены белорусских компаний"). While great for SEO, screen readers will read this entire string out loud on every single page load, which can be a poor accessibility experience. It is usually a best practice to keep decorative or repeating logo alt tags concise (e.g., alt="TokenBel").
  • index.html: Excellent work changing the text-gray-300 classes to text-gray-500 for the separators. The lighter gray on a white background failed WCAG contrast ratio guidelines, and this small change significantly improves accessibility.

📊 Final Assessment

  • Rating: Normal
  • Reason: While the SEO metadata and accessibility tweaks are well-implemented, the PR is currently blocked by a critical domain mismatch in the sitemaps that must be reverted to avoid breaking the site's search engine indexing. The custom registry dependency resolution in bun.lock also warrants verification.

@AndreiDrang
AndreiDrang merged commit e3e296a into prod Jul 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant